Magnus' TLS nits #4205
Merged
Magnus' TLS nits #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... that after Retry the use of the new Destination Connection ID does not provide address validation (this was previously obtusely stated). Note that this critically says that a Destination Connection ID of any length is not sufficient to prove that the server got the packet. This is because the client doesn't know how hard the value is to guess, even if the value is 8 byte or more long and might appear to contain sufficient entropy (it could be a deterministic function of the client address, for example).
martinthomson
added
editorial
seanturner
approved these changes
Oct 14, 2020
ianswett
approved these changes
Oct 14, 2020
gloinul
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all small, but neat improvements inspired by the feedback in #4204.
Closes #4204.